FVWM3 crashes with VLC

[sebaro1]

FVWM crashes when video ends playback or when I close the app.

fvwm3 1.0.6 (1.0.5-15-gd6d9fbb8-dirty)
with support for: ReadLine, XPM, PNG, SVG, Shape, XShm, SM, XRandR, XRender, XCursor, XFT, NLS

fvwm config
gist

fvwm log

[1667649473.780481] convert_charsets: Invalid byte sequence during conversion from UTF-8 to ISO-8859-1
[1667649473.781790] setup_window_placement: Expanding screen from ‘null’ → ‘’
[1667649519.212012] setup_window_placement: Expanding screen from ‘null’ → ‘’
[1667675635.370106] FScreenInit: Using RandR 1.6
[1667675635.399279] main: Loading window states via (null)
[1667675635.430951] FlocaleGetFontSet: [fvwm][FlocaleGetFontSet]: (--fixed-medium-r-semicondensed--13-------,--fixed-medium-r-normal--14-------,---medium-r-normal--16-------) Missing font charsets:
[1667675635.430981] FlocaleGetFontSet: KSC5601.1987-0
[1667675635.430989] FlocaleGetFontSet: ,
[1667675635.430996] FlocaleGetFontSet: GB2312.1980-0
[1667675635.431003] FlocaleGetFontSet:
[1667675635.457333] initPanFrames: freeing panframes
[1667675635.457373] initPanFrames: finished setting up per-monitor panframes
[1667675635.457881] CMD_EwmhBaseStruts: mon: HDMI-A-1 {l: 10, r: 10, t: 10, b: 50}
[1667675636.185443] setup_window_placement: Expanding screen from ‘null’ → ‘’
[1667675636.430705] setup_window_placement: Expanding screen from ‘null’ → ‘’
[1667675636.533290] setup_window_placement: Expanding screen from ‘null’ → ‘’
[1667675692.331737] convert_charsets: [fvwm][convert_charsets]: WARNING -

It doesn’t crash with cvlc only with the gui version (Qt).
It doesn’t crash with the default config (-f /dev/null).

[somiaj]

Is this something new? Was it working before but some current update has changed behavior? If so you should try 1.0.5 or 1.0.4, and then use git-bisect to narrow down the commit that caused the problem.

As for using the default-config, you are using a ‘blank config’, instead you should use the default-config, you can either just move your configuration out of the way temporally, and it will load the default-config if no other config file is found, or you can find it in $PREFIX/share/fvwm3/default-config/config, and see if that works as well.

Your config is a bit hard to parse (and due to Reads missing bits), but anyways, if you can either track down the commit that cause this to start crashing (if it ever worked) or track down some minimal configuration that causes it to break so it can be tested, then report an issue on github.

Note, the default configuration (if no configuration is found) will read $FVWM_USERDIR/local.config, so if it works in the default config, you can add just the changes to local.config that cause it to crash and share that for testing.

[sebaro1]

It’s the same with the default config.
Gentoo has only two versions 1.0.4 and live/git, with 1.0.4 there’s no crash so some commit after this release causes this. I’ll check.

Edit: crashes with 1.0.5 too.

[somiaj]

I installed VLC here (Debian bullseye), and I don’t get a crash when it finished playing a video or when I closed the app. So might be some issue in VLC in your setup too. Though since some change in fvwm since 1.0.4 is causing the crash, might be a combination of things (makes it harder to debug).

Building from source and using git-bisect until you can narrow down exactly which commit caused the change on your system could help narrow down what in fvwm could have caused the issue, but since I cannot reproduce the issue, I am unable to do the testing.

[sebaro1]

git-bisect result, should I open a bug report?

320ae7aa230106647246d7b19b83a4630956fc93 is the first bad commit
commit 320ae7aa230106647246d7b19b83a4630956fc93
Author: Dominik Vogt <dominik.vogt@gmx.de>
Date:   Fri Nov 26 21:41:37 2021 +0100

    Fix fvwm missing DestroyNotify events that died before reparenting.

 fvwm/add_window.c | 39 ++++++++++++++++++++++++++++++---------
 1 file changed, 30 insertions(+), 9 deletions(-)

[somiaj]

Yes, add an issue to github (https://github.com/fvwmorg/fvwm3/issues), so it can be looked at.