After restarting FVWM, the buttons in RightPanel show the incorrect desk. When I am on a desk other than 0 and restart FVWM, the pager displays the correct desk, but the wrong button appears to be higligted.
Using “ChangeDesk $[desk.n]” in fvwm-console seems to fix the issue, but I haven’t managed to make it work from the start function. Currently, I include this command in the shortcut I use to pop up the panel. However, this is not an elegant solution. Ideally, I would like the buttons to retain their visible status from before the restart. Does anyone have any ideas on how to resolve this?
As I mentioned, we can trigger it to correct. Please test my second example, which uses a key binding to a function call. I am puzzled as to why it needs to be triggered from a key binding to a function call, and not directly from a key binding or the start function. In StartFunction, I have been testing with very long schedules (schedule 50000), so it’s probably not a timing issue.
Doesn’t seem to have any good solution. Usually, Schedule does it but not for ChangeDesk $[desk.n]. Annoying, the Right Panel gets stuck until updated. A mouse click at another desk does it but not ok.
@dante65, This is most likely a bug in how RightPanel is launched from the StartFunction. In this case it is configured to always show Desk 0 as highlighted, and the event to change this doesn’t happen until a desk change is triggered.
As mentioned the Schedule method can work, but really is more a work around and is subject to race conditions. Another option might be to add some Test to the RightPanel configuration to highlight the correct desk. I will think about this a bit, but I know what is going on, just unsure the best way to fix the issue.
The reason is how variable expansion works, when you just make a key binding, $[desk.n] gets expanded to the desk at the time the key binding is made, not the time it is pressed.
When you wrap the update into a function, the expansion of $[desk.n] happens when the function is run, so it will always get the current desk.
Actually seems my previous idea was incorrect, I think the issue is during the restart, the current desk isn’t set until after $[desk.n] expands, I’m looking into this more, as my fix didn’t work in this case.
Currently when restarting fvwm, the previous saved session (such as what desktop you are currently own) isn’t restored until after the configuration file is read and StartFunction is run, so that is why something like schedule is needed, or function/keybinding after fvwm has started works. This means the value of $[desk.n] will be 0 until after fvwm starts.
The only solution I can think of that won’t require a race condition is to use an environment variable to save the current desk, and use something like FvwmEvent to update this environment variable each time the desk is changed. So there are solutions, but currently no easy solution.
### Save current Desk on restart
AddToFunc ExitFunction
+ I Test (ToRestart) InfoStoreAdd DeskNo "0 $[desk.n]"
+ I GoToDesk 0 0
# Show previous Desk on restart
AddToFunc StartFunction
+ I Test (Restart) Schedule 500 GoToDesk $[infostore.DeskNo]
+ I Test (Restart) InfoStoreRemove DeskNo
It works fine on RightPanel, as well as on the KISe Desk/Page indicator config.
Though this really isn’t the best solution. Why not just update the buttons and not worry about changing desks. There would be no need to change the desk in an environment variable this way either. Here is a solution for the actual issue problem here which is the RightPanel, just update the desk shortly after restarting.
AddToFunc StartFunction I Schedule 500 ChangeDesk $[monitor.$[monitor.primary].desk]
